Add subcmd add#914
Conversation
ken-matsui
left a comment
ken-matsui
left a comment
There was a problem hiding this comment.
Thanks for your time to work on this! I put several comments for performance and style consistency.
ken-matsui
left a comment
ken-matsui
left a comment
There was a problem hiding this comment.
Thank you for your time again! Just a few things. Can you please also deal with the clang-tidy error?
|
All fixed including the clang-tidy error |
|
@SunPodder Sorry, there are more clang-tidy errors. Could you please address them? (After that, LGTM) |
Allows users to add project dependencies to poac.toml from the commandline
|
Sorry, it must be annoying for you reviewing the same mistakes. clang-tidy throws errors on my machine even for existing codes which are correct and passes on ci. So it's hard to make sure everything is fine :) |
|
No worries! Which version of clang-tidy are you using? |
clang-tidy-15 |
|
It seems that clang-tidy-17 fixed the problem, just fyi: llvm/llvm-project#46097. |
ken-matsui
left a comment
ken-matsui
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
|
@SunPodder Can you also update README.md for this command? |
|
Sure |
2 participants
No description provided.